Change in ovirt-engine[ovirt-engine-3.5]: core: minor refactor for custom props validation

tnisan at redhat.com tnisan at redhat.com
Mon Nov 24 09:27:37 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: minor refactor for custom props validation
......................................................................


core: minor refactor for custom props validation

instead of calling one method to check the properties and then another
to check the result, now calling one method to do both.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1166632
Change-Id: I444f374d0c1bb4c495b3c2b1c26c92bc466e19c9
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/VmPropertiesUtils.java
7 files changed, 21 insertions(+), 28 deletions(-)

Approvals:
  Omer Frenkel: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I444f374d0c1bb4c495b3c2b1c26c92bc466e19c9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list