Change in ovirt-engine[master]: engine: Ensure that all networks on NIC have QoS

lvernia at redhat.com lvernia at redhat.com
Mon Nov 24 23:54:27 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: engine: Ensure that all networks on NIC have QoS
......................................................................


engine: Ensure that all networks on NIC have QoS

Because of various damaging edge cases where some networks have QoS
configured on top of one logical interface while others don't, this
blocks a setup networks operation if only some of the networks on the
interface have it configured.

Change-Id: I59bf1bd6fcd26c3229cf0068d06e643b1abe1003
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 110 insertions(+), 13 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34132
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I59bf1bd6fcd26c3229cf0068d06e643b1abe1003
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list