Change in ovirt-engine[master]: core: Moved disk alias genenration in AddDiskCommand to exec...

tnisan at redhat.com tnisan at redhat.com
Thu Nov 27 20:15:53 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Moved disk alias genenration in AddDiskCommand to execution
......................................................................


core: Moved disk alias genenration in AddDiskCommand to execution

Moved the disk alias generation in AddDiskCommand to the execution phase
as in the job properties calculation the VM disk map is not yet populated.
Also the disk alias was omitted from the execution message as we cannot
assure that in 100% of the times a disk alias will be specified (the VM
name is not there for the same reason)

Bug-Url: https://bugzilla.redhat.com/1168252
Signed-off-by: Tal Nisan <tnisan at redhat.com>
Change-Id: Id30fa5d3a99dd12b8c45633d592d017c3a6ffd1b
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
2 files changed, 2 insertions(+), 10 deletions(-)

Approvals:
  Tal Nisan: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id30fa5d3a99dd12b8c45633d592d017c3a6ffd1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list