Change in ovirt-engine[ovirt-engine-3.5]: restapi: copy instance type fields to the VM

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Nov 28 13:48:35 UTC 2014


Piotr Kliczewski has submitted this change and it was merged.

Change subject: restapi: copy instance type fields to the VM
......................................................................


restapi: copy instance type fields to the VM

As a consequence of the https://bugzilla.redhat.com/1149663 the instance type
fields are not copied to the VM on server anymore and frontends
(WA/UP/REST) need to take care of it.

More specifically it works like this:

If only the instance type is selected, it has to copy its properties to the
newly created VM (on VM level this can be overridden)

If both the template and the instance type is selected, the instance type
overrides the template.

When copying the parameters from instance type to the VM, only the ones which
are supported on the target cluster/OS are taken into account.

Change-Id: Id8ff7a39fe74c73d8984fb34169b69649dab7c15
Bug-Url: https://bugzilla.redhat.com/1149663
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
4 files changed, 213 insertions(+), 123 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Juan Hernandez: Looks good to me, approved
  Michal Skrivanek: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/35427
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id8ff7a39fe74c73d8984fb34169b69649dab7c15
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list