Change in ovirt-engine[ovirt-engine-3.5]: engine: handle memory allignment when checking the balloon h...

tnisan at redhat.com tnisan at redhat.com
Sun Nov 30 13:31:54 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: engine: handle memory allignment when checking the balloon health
......................................................................


engine: handle memory allignment when checking the balloon health

Engine used to check if the ballooning works properly
by comparing the target memory with the actual available
memory and throws a warning if it doesn't match,
the problem is when the requsted target memory value is
not alligned. The system then returns the alligned memory
and the engine thinks the balloon is not working, becuase
the requested value != curent value. This patch changes
the behaviour so it only checks if the current value is closer
to the requested value than the previous value (in other words:
if the current memory moves towards the requested target)

Change-Id: Ibc308a2049c117e2409f480adfcd4a3da495a0b9
Bug-Url: https://bugzilla.redhat.com/1120197
Signed-off-by: Jiri Moskovcak <jmoskovc at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBalloonInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java
3 files changed, 51 insertions(+), 1 deletion(-)

Approvals:
  Martin Sivák: Looks good to me, but someone else must approve
  Jiří Moskovčák: Verified
  Doron Fediuck: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35585
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc308a2049c117e2409f480adfcd4a3da495a0b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Jiří Moskovčák <jmoskovc at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list