Change in ovirt-engine[ovirt-engine-3.5]: core:fixing step numbering for steps and sub-steps

tnisan at redhat.com tnisan at redhat.com
Wed Oct 1 14:04:56 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core:fixing step numbering for steps and sub-steps
......................................................................


core:fixing step numbering for steps and sub-steps

When a step is added to a job, it should get its step_number value
according to the existing steps already added to the job.
The same is for adding sub-step to an exiting step.

This patch fix a problem in adding step/sub-step when all added
steps/sub-steps get a 0 for the step_number value.

This resulted in incorrect order of steps and sub-steps in the UI while
steps where ordered by the step_number but this had no affect
since the step_number was always 0.

Change-Id: Ic72e9ab64160116f4fbac3f3b2cdea63db7b9c75
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148466
Signed-off-by: Eli Mesika <emesika at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
3 files changed, 20 insertions(+), 0 deletions(-)

Approvals:
  Eli Mesika: Verified
  Moti Asayag: Looks good to me, approved
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33622
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic72e9ab64160116f4fbac3f3b2cdea63db7b9c75
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list