Change in ovirt-engine[ovirt-engine-3.5]: core: AddVmTemplateCommand storage allocation

tnisan at redhat.com tnisan at redhat.com
Thu Oct 2 08:33:50 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: AddVmTemplateCommand storage allocation
......................................................................


core: AddVmTemplateCommand storage allocation

This patch is a part of a series of patches, adding storage allocation
validations to the system when they're missing, and replacing old
verification usage with unified, new, correct and tested verification.
This patch did this for AddVmTemplateCommand, using only existing
validations. Removing old verification in this command resulted in
unused old validation and validation aids, which were also removed in
this patch.

Change-Id: I7980510a7bb72e43e0a9dfc18460207386eb62fe
Bug-Url: https://bugzilla.redhat.com/1053744
Signed-off-by: Vered Volansky <vvolansk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java
3 files changed, 117 insertions(+), 52 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Vered Volansky: Verified



-- 
To view, visit http://gerrit.ovirt.org/33695
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7980510a7bb72e43e0a9dfc18460207386eb62fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list