Change in ovirt-engine[ovirt-engine-3.5]: webadmin: use new element-id-capable SortedColumn for vm sta...

tnisan at redhat.com tnisan at redhat.com
Tue Oct 21 08:02:38 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: use new element-id-capable SortedColumn for vm statustext
......................................................................


webadmin: use new element-id-capable SortedColumn for vm statustext

In the VM main tab, the 'status text' column lost its static element id,
probably when it was made into a SortedColumn or a composite column.
Added infrastructure for a SortedColumnWithElementId and switched the
column to that.

Change-Id: I97bb0a04d46e94efede5f46af35ebcee01a9dd70
Bug-Url: https://bugzilla.redhat.com/1148530
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCellWithElementId.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CellWithElementId.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CompositeCellWithElementId.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SortableColumnWithElementId.java
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
6 files changed, 156 insertions(+), 12 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Greg Sheremeta: Verified



-- 
To view, visit http://gerrit.ovirt.org/34280
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97bb0a04d46e94efede5f46af35ebcee01a9dd70
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list