Change in mom[master]: HostKSM: Gracefully handle ksmd pid lookup failure

alitke at redhat.com alitke at redhat.com
Thu Oct 23 18:39:45 UTC 2014


Adam Litke has submitted this change and it was merged.

Change subject: HostKSM: Gracefully handle ksmd pid lookup failure
......................................................................


HostKSM: Gracefully handle ksmd pid lookup failure

In case the pid of ksmd cannot be found we currently fail with a
ValueError exception.  Check the pidof return code before trying to
convert the output to an int.  If the pid cannot be found, then report 0
for get_ksmd_jiffies().

Change-Id: Iccd14ee44f4f7d8d9107e692c9faa27e7c487790
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152182
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/34378
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M mom/Collectors/HostKSM.py
1 file changed, 14 insertions(+), 3 deletions(-)

Approvals:
  Adam Litke: Verified; Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/34378
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iccd14ee44f4f7d8d9107e692c9faa27e7c487790
Gerrit-PatchSet: 3
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list