Change in ovirt-engine-cli[master]: cli: Allow identifiers that aren't UUIDs

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Oct 28 09:57:18 UTC 2014


Juan Hernandez has submitted this change and it was merged.

Change subject: cli: Allow identifiers that aren't UUIDs
......................................................................


cli: Allow identifiers that aren't UUIDs

Currently we assume that the identifiers of objects are always UUIDs, but this
isn't true, as some objects like network labels use arbitrary strings as
identifiers, and the show commands doesn't work with them:

  [oVirt shell (connected)]# list labels \
    --network-identifier ovirtmgmt \
    --datacenter-identifier mydc

  id         : mylabel

  [oVirt shell (connected)]# show label \
    --network-identifier ovirtmgmt \
    --datacenter-identifier mydc \
    mylabel

  ============ ERROR ============
    label mylabel does not exist.
  ===============================

This patch removes that limitation so that the show command works correctly:

  [oVirt shell (connected)]# show label \
    --network-identifier ovirtmgmt \
    --datacenter-identifier mydc \
    mylabel

  id        : mylabel
  network-id: 4e31cd25-501e-47e4-a8b2-96b57a96a7e3

Change-Id: I2f3da6c3fd307ce9933c9d11d9ada4c4ff772e88
Bug-Url: https://bugzilla.redhat.com/1148941
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 1 insertion(+), 21 deletions(-)

Approvals:
  Michael Pasternak: Looks good to me, approved
  Ravi Nori: Looks good to me, but someone else must approve
  Juan Hernandez: Verified



-- 
To view, visit http://gerrit.ovirt.org/34207
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f3da6c3fd307ce9933c9d11d9ada4c4ff772e88
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520 at yahoo.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list