Change in ovirt-engine[master]: webadmin: Template's empty string as a disk alias UI fix.

tnisan at redhat.com tnisan at redhat.com
Wed Oct 29 12:22:38 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Template's empty string as a disk alias UI fix.
......................................................................


webadmin: Template's empty string as a disk alias UI fix.

While making a new template based on a VM, providing the template's
allocated disks's alias as an empty string is now disabled ALSO BY UI.
the user should not be able to create a template with disks that have
an empty aliases- this bug has already been fixed at the BACKEND, this
current patch prevents the user from giving an empty alias at UI level.

Change-Id: I246063773e423f1e34ace3acd3f3884b282597e7
Bug-Url: https://bugzilla.redhat.com/1110304
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
2 files changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Amit Aviram: Verified



-- 
To view, visit http://gerrit.ovirt.org/34477
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I246063773e423f1e34ace3acd3f3884b282597e7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list