Change in ovirt-engine[master]: core: Renamed the getStorageDomainId Method

tnisan at redhat.com tnisan at redhat.com
Thu Oct 30 10:41:45 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Renamed the getStorageDomainId Method
......................................................................


core: Renamed the getStorageDomainId Method

The method's name implies that it's a simple getter, even though it does
not always return the expected storage domain even if it exists
(permissions issues for example).
Thus, renamed to getStorageDomainIdForQuery.

Change-Id: I93e7fdda6ffacb0fc1fd740fe69390864100ab7b
Related-To: https://bugzilla.redhat.com/1085398
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQueryTest.java
4 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Maor Lipchuk: Looks good to me, approved
  Idan Shaby: Verified



-- 
To view, visit http://gerrit.ovirt.org/34028
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I93e7fdda6ffacb0fc1fd740fe69390864100ab7b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list