Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin, branding: fix PatternFly impl for IE8

tnisan at redhat.com tnisan at redhat.com
Thu Oct 30 14:29:15 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: userportal, webadmin, branding: fix PatternFly impl for IE8
......................................................................


userportal, webadmin, branding: fix PatternFly impl for IE8

Our PatternFly implementation was not IE8 compliant. Needed to add
respond.js and html5shiv.js. Everything now looks good in IE8.

Major caveat with respond.js is that it will not follow CSS @import's,
and we used them heavily. Changed branding to allow multiple CSS
files as part of a branding theme. Then changed ovirt-brand to use
all of the CSS files directly and removed all @import's. So now instead
of ovirt-brand depending on one CSS file and that file importing a chain,
all individual files are now referenced by the brand directly.

Change-Id: I4b40eef0a1dbdab93d55ab5ea6c25bb9e70714c5
Bug-Url: https://bugzilla.redhat.com/1152656
Bug-Url: https://bugzilla.redhat.com/1152646
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java
M backend/manager/modules/branding/src/main/resources/META-INF/obrand.tld
A backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag
M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/stylesheets.tag
M backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingThemeTest.java
M backend/manager/modules/branding/src/test/resources/org/ovirt/engine/core/branding/01-test.brand/branding.properties
M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ReportsNotInstalled.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp
M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp
M packaging/branding/ovirt.brand/branding.properties
M packaging/branding/ovirt.brand/common.css
M packaging/branding/ovirt.brand/user_portal.css
M packaging/branding/ovirt.brand/web_admin.css
M packaging/branding/ovirt.brand/welcome_style.css
17 files changed, 59 insertions(+), 31 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Greg Sheremeta: Verified



-- 
To view, visit http://gerrit.ovirt.org/34567
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b40eef0a1dbdab93d55ab5ea6c25bb9e70714c5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list