Change in ovirt-engine[master]: engine: Change reorder vNIC action's permissions

lvernia at redhat.com lvernia at redhat.com
Mon Sep 1 15:01:51 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: engine: Change reorder vNIC action's permissions
......................................................................


engine: Change reorder vNIC action's permissions

Changed the aforementioned action to belong to ActionGroup.CREATE_VM
rather than ActionGroup.CONFIGURE_VM_NETWORK, as it's an integral part
of the process of creating a VM (it shouldn't be called in the context
of a pre-existing VM in order to re-arrange its NICs).

This might seem askew - this whole command can (and likely should) be
a part of the Create VM command, if that is changed to receive as a
parameter a list of NICs to create.

Change-Id: Iaef9b2e9ae9258210f48b59d89467247ff9a2468
Bug-Url: https://bugzilla.redhat.com/1134554
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Lior Vernia: Verified
  Moti Asayag: Looks good to me, approved
  Oved Ourfali: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/32226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaef9b2e9ae9258210f48b59d89467247ff9a2468
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list