Change in ovirt-engine[ovirt-engine-3.5]: restapi: Enable eject of cdrom via REST

tnisan at redhat.com tnisan at redhat.com
Wed Sep 3 15:43:24 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: restapi: Enable eject of cdrom via REST
......................................................................


restapi: Enable eject of cdrom via REST

Modified parameter validation to allow for files witout set id.

Also needed to normalize representation of "EJECT" as empty string on
backend in case `null` is received from REST api.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1135970
Change-Id: Ia11068f319bcb5cf0ff1facedd9cb99ce4c9e5d0
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResourceTest.java
3 files changed, 18 insertions(+), 16 deletions(-)

Approvals:
  Juan Hernandez: Looks good to me, but someone else must approve
  Martin Betak: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32407
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia11068f319bcb5cf0ff1facedd9cb99ce4c9e5d0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list