Change in ovirt-engine[ovirt-engine-3.5]: core: Consolidated common test of add/update storage connection

tnisan at redhat.com tnisan at redhat.com
Thu Sep 4 14:31:33 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Consolidated common test of add/update storage connection
......................................................................


core: Consolidated common test of add/update storage connection

AddStorageServerConnection and UpdateStorageServerConnection command tests
contained simiar tests, those common tests were extracted to a parent test
class for better readability and easier maintenance

Change-Id: Iad571ca0c5788c375200847e8872706a8dfd7f3e
Bug-Url: https://bugzilla.redhat.com/1129597
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionTestCommon.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java
3 files changed, 148 insertions(+), 195 deletions(-)

Approvals:
  Tal Nisan: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32488
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iad571ca0c5788c375200847e8872706a8dfd7f3e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list