Change in ovirt-engine[master]: frontend: Fix validation of UnitVmModel

awels at redhat.com awels at redhat.com
Tue Sep 9 15:27:03 UTC 2014


Alexander Wels has submitted this change and it was merged.

Change subject: frontend: Fix validation of UnitVmModel
......................................................................


frontend: Fix validation of UnitVmModel

Individual entity models were validated but the validate() method always
returned true since the validity of individual tabs was not taken into
account. This resulted in submitting invalid edits and subsequent
backend validation errors.

Change-Id: Iabba7f93a0541292a1a4c82b675ab0faf141b9b2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128444
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
2 files changed, 11 insertions(+), 14 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, but someone else must approve
  Alexander Wels: Looks good to me, approved
  Martin Betak: Verified



-- 
To view, visit http://gerrit.ovirt.org/32645
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iabba7f93a0541292a1a4c82b675ab0faf141b9b2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list