Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix validation of UnitVmModel

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Sep 12 08:57:47 UTC 2014


Piotr Kliczewski has submitted this change and it was merged.

Change subject: frontend: Fix validation of UnitVmModel
......................................................................


frontend: Fix validation of UnitVmModel

Individual entity models were validated but the validate() method always
returned true since the validity of individual tabs was not taken into
account. This resulted in submitting invalid edits and subsequent
backend validation errors.

Change-Id: Iabba7f93a0541292a1a4c82b675ab0faf141b9b2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128444
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
1 file changed, 18 insertions(+), 13 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Martin Betak: Verified



-- 
To view, visit http://gerrit.ovirt.org/32694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iabba7f93a0541292a1a4c82b675ab0faf141b9b2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list