Change in ovirt-engine[master]: core: allowed to add network label even if Vm using this net...

lvernia at redhat.com lvernia at redhat.com
Mon Sep 15 14:14:04 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: core: allowed to add network label even if Vm using this network is running.
......................................................................


core: allowed to add network label even if Vm using this network is
running.

Network label was checked to be unchanged in method
'onlyPermittedFieldsChanged'. This is extracted out into new method
'allowedNetworkLabelManipulation' which returns true if network label
was not changed, or if former label was not specified (null) and new
one is specified (!=null).

Change-Id: I57a658a4e2d4648917a265493cde4749ad15e3ad
Bug-Url: https://bugzilla.redhat.com/1134009
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
1 file changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Martin Mucha: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32688
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I57a658a4e2d4648917a265493cde4749ad15e3ad
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list