Change in ovirt-engine[ovirt-engine-3.5]: webadmin: The text and buttons not aligned in Create VM dialog

tnisan at redhat.com tnisan at redhat.com
Wed Sep 17 07:06:35 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: The text and buttons not aligned in Create VM dialog
......................................................................


webadmin: The text and buttons not aligned in Create VM dialog

The http://gerrit.ovirt.org/#/c/30821 enhanced the "Guide Me" dialog so also
the bigger text will fit in. The problem with this patch is that it uses the
"display: flex" which is not supported by firefox 17 and firefox 17 is the only
browser supported by oVirt.

So this patch "reverts" this fix and applyes the one proposed here:
http://gerrit.ovirt.org/#/c/30861/ which does not look so nice but works also
on older browsers.

This patch also contains the http://gerrit.ovirt.org/#/c/32830/ which moves the
arrow in the login button of the iSCSI domain to the middle.

Change-Id: Ifcb74f036476fb8544d1f15d26a0ef92e2eeed46
Bug-Url: https://bugzilla.redhat.com/1135965
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
4 files changed, 16 insertions(+), 4 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Daniel Erez: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcb74f036476fb8544d1f15d26a0ef92e2eeed46
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list