Change in ovirt-engine[ovirt-engine-3.5]: core: Don't write empty description/comment to OVF

tnisan at redhat.com tnisan at redhat.com
Tue Sep 23 14:29:01 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Don't write empty description/comment to OVF
......................................................................


core: Don't write empty description/comment to OVF

Currently when we generate OVF files we write the description and
comment properties of the VM even if they are null. As a result when a
VM without a description or comment is re-imported it has an empty
string a value (instead of null) for these properties. This patch
changes the OVF writer so that it won't write the description or comment
properties if they are null.

Change-Id: Iffd0f7010bc32402c45882dc6087bf02a55a14d9
Bug-Url: https://bugzilla.redhat.com/1145466
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit cbd16554817f0373df18018bd65795412972544f)
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
1 file changed, 10 insertions(+), 6 deletions(-)

Approvals:
  Juan Hernandez: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iffd0f7010bc32402c45882dc6087bf02a55a14d9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list