Change in ovirt-engine[master]: webadmin: DiskStorageType instead of isInternal flag

derez at redhat.com derez at redhat.com
Mon Sep 29 12:40:14 UTC 2014


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: DiskStorageType instead of isInternal flag
......................................................................


webadmin: DiskStorageType instead of isInternal flag

Disk Dialog:
Use DiskStorageType enum instead of isInternal flag to
support extendability of future disk types.

Change-Id: I6550d85062dbff324591c2b790e0192c21dabf18
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java
4 files changed, 60 insertions(+), 63 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33152
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6550d85062dbff324591c2b790e0192c21dabf18
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list