Change in ovirt-engine[master]: core: RepoFileMetaDataDAOTest equality assertions

amureini at redhat.com amureini at redhat.com
Thu Apr 9 11:53:39 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: RepoFileMetaDataDAOTest equality assertions
......................................................................


core: RepoFileMetaDataDAOTest equality assertions

Fixed all equality based assertions to use the standard assertEquals
method instead of explicitly calling equals or ==.
assertSame calls were also removed, since although they are not strictly
wrong, assertSame should be used to check identity, not primitive
equality.

Change-Id: I41a5ada68caf3421d9330b6f5a591dee98903096
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java
1 file changed, 7 insertions(+), 15 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/39711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41a5ada68caf3421d9330b6f5a591dee98903096
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list