Change in ovirt-engine[master]: restapi: Remove empty bodies from RSDL metadata file

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Apr 15 08:57:06 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Remove empty bodies from RSDL metadata file
......................................................................


restapi: Remove empty bodies from RSDL metadata file

Currently the RSDL metadata file contains the definition of request
bodies even if they are completely empty. For example:

  body:
    parameterType: null
    signatures: []

This is currently needed because otherwise the list of signatures would
be "null" instead of an empty list, and that would induce some changes
in the generated RSDL. To avoid all these empty specifications (that
make the already giantic RSDL metadata file even larger) this patch
changes the RSDL builder so that it assigns default values to the
metadata after loading it (replacing "null" with empty lists, for
exampe) and also removes the empty specifications from the RSDL metadata
file. The generated RSDL document doesn't change.

Change-Id: I1a95ca58b83750886429bce29a0e8e9188c76d48
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
2 files changed, 61 insertions(+), 1,143 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/39665
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a95ca58b83750886429bce29a0e8e9188c76d48
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list