Change in ovirt-engine-sdk[master]: sdk: Always generate the tarball when building RPMs

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Apr 21 08:39:51 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: sdk: Always generate the tarball when building RPMs
......................................................................


sdk: Always generate the tarball when building RPMs

Currently when building a RPM the tarball is generated using the "git
archive" command and the HEAD tree. This means that changes that haven't
been locally commited aren't included in the result. In addition the
tarball is only generated if there were changes in the Makefile or the
.spec template, which has the same effect. To avoid these two issues
this patch changes the command used to build the tarball and also
changes the Makefile so that the tarball is always regenerated.

Change-Id: Ib16253e18f39ff4bafef1fcdebe21e8f456b4b23
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M Makefile
M ovirt-engine-sdk-python.spec.in
2 files changed, 34 insertions(+), 29 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/39854
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib16253e18f39ff4bafef1fcdebe21e8f456b4b23
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list