Change in ovirt-engine-cli[master]: cli: Add "parent" prefix to parent identifier options

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Apr 28 13:19:52 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: cli: Add "parent" prefix to parent identifier options
......................................................................


cli: Add "parent" prefix to parent identifier options

Currently the way to specify the identifier of a parent entity is to use
the "--*-identifier" or "--*-name" options. These option, specially the
"name" option, may conflict with other options used to populate the
request. For example, when adding a storage domain the "--host-name"
option is used to indicate what host name should perform the operation,
but the CLI assumes that it is used to specify the parent host, which
doesn't make sense. This patch changes the CLI so that it will require
the "parent" prefix in the option used to specify the parent name. The
option used to specify the parent identifier will also support the
"parent" prefix, but it will still work without it, for backwards
compatibility.

Change-Id: I4150389b6c87cc178865757f99a2e09e272c530f
Bug-Url: https://bugzilla.redhat.com/1213393
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M src/ovirtcli/command/action.py
M src/ovirtcli/command/add.py
M src/ovirtcli/command/command.py
M src/ovirtcli/command/list.py
M src/ovirtcli/command/remove.py
M src/ovirtcli/command/show.py
M src/ovirtcli/command/update.py
M src/ovirtcli/utils/autocompletionhelper.py
8 files changed, 82 insertions(+), 50 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/40054
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4150389b6c87cc178865757f99a2e09e272c530f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list