Change in ovirt-engine[master]: core: GetErrataCountsForVmQuery with null VM

amureini at redhat.com amureini at redhat.com
Sun Aug 9 11:30:11 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: GetErrataCountsForVmQuery with null VM
......................................................................


core: GetErrataCountsForVmQuery with null VM

This query should fail if the relevant VM is null. However, this check
is done too late, and the VM is already used before it, which will, of
course, result in a NullPointerException.

This patch fixes Coverity CID 1315379.

Change-Id: Ic409124b15631a8217230d02a02af09ceaeef314
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataCountsForVmQuery.java
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/44529
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic409124b15631a8217230d02a02af09ceaeef314
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list