Change in ovirt-engine[master]: core: Use proper substitution in HostDev commands' canDoActions

tjelinek at redhat.com tjelinek at redhat.com
Mon Aug 10 14:25:10 UTC 2015


Tomas Jelinek has submitted this change and it was merged.

Change subject: core: Use proper substitution in HostDev commands' canDoActions
......................................................................


core: Use proper substitution in HostDev commands' canDoActions

Added missing action message parameters and status localization
to Add/Remove Host Device Commands.

Also added missing type HOST_DEVICES to webadmin's AppErrors.

Change-Id: Ib68484f0d363203aedff3d49a7ae453246e4acd1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1247041
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AbstractVmHostDevicesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AddVmHostDevicesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RemoveVmHostDevicesCommand.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 20 insertions(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Martin Betak: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/44421
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib68484f0d363203aedff3d49a7ae453246e4acd1
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list