Change in ovirt-engine[ovirt-engine-3.6]: core: add missing null check on proceedBalloonCheck

tnisan at redhat.com tnisan at redhat.com
Wed Aug 12 10:54:09 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: add missing null check on proceedBalloonCheck
......................................................................


core: add missing null check on proceedBalloonCheck

When host has balloon enabled, and vm is not reported by vdsm,
there is NPE in proceedBalloonCheck because vdsmVm is null.

also log monitoring exceptions stack trace in error, these errors are
important enough to be fully logged when happen.

Change-Id: Ibc08dbb8e8448049b07bee5130a5654501df28fe
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252012
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java
3 files changed, 16 insertions(+), 5 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Omer Frenkel: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/44705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc08dbb8e8448049b07bee5130a5654501df28fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list