Change in ovirt-engine[ovirt-engine-3.6]: sercon: minor ovirt-vmconsole-list.py cleanups

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Aug 14 09:47:52 UTC 2015


Piotr Kliczewski has submitted this change and it was merged.

Change subject: sercon: minor ovirt-vmconsole-list.py cleanups
......................................................................


sercon: minor ovirt-vmconsole-list.py cleanups

- add debug command line option
- leverage ovirt-configured logging
- use specific logger: was using top level logger (logging.something())
  because of a typo.
- make sure we close the file-like returned by urllib2.
- make sure to logs exceptions on syslog

Bug-Url: https://bugzilla.redhat.com/1223671
Change-Id: Ie5323da99c2709b51fe043b492860140aad5af5a
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py
1 file changed, 37 insertions(+), 18 deletions(-)

Approvals:
  Piotr Kliczewski: Passed CI tests
  Sandro Bonazzola: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/44814
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5323da99c2709b51fe043b492860140aad5af5a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list