Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix of NPE in DedicatedVmForVdsUnitToVmBaseBuilder

tnisan at redhat.com tnisan at redhat.com
Mon Aug 17 14:01:59 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Fix of NPE in DedicatedVmForVdsUnitToVmBaseBuilder
......................................................................


webadmin: Fix of NPE in DedicatedVmForVdsUnitToVmBaseBuilder

UnitVmModel#defaultHost was (not completely) refactored to allow
selection of multiple hosts to pin to.
VmModelBehaviorBase#updateDefaultHost() still worked with
ListModel#selectedItem instead of #selectedItems. This caused NPE
in DedicatedVmForVdsUnitToVmBaseBuilder.

Change-Id: I36d73f5b301e71b0baf09c4bcef1d20a7379fed8
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1247932
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/TakesConstrainedValueListEditor.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
2 files changed, 17 insertions(+), 11 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/44922
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36d73f5b301e71b0baf09c4bcef1d20a7379fed8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list