Change in ovirt-engine-cli[master]: cli: Generate parse tables during build

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Aug 25 12:51:18 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: cli: Generate parse tables during build
......................................................................


cli: Generate parse tables during build

Currently the parse tables used by ply are generated during the RPM
installation, or, for non RPM platforms, during runtime. This causes
warnings because the user running the CLI may not have permissions to
write those parse tables. To avoid those warnings this patch changes the
CLI build process so that the parse tables are generated from the
"setup.py" script and included in the binary distribution.

Change-Id: I933a56b3ccbf5bc0e39feed9a2c61be89970dd84
Bug-Url: https://bugzilla.redhat.com/1255409
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M ovirt-engine-cli.spec.in
M setup.py
M src/cli/plyparse.py
3 files changed, 36 insertions(+), 15 deletions(-)

Approvals:
  Ori Liel: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/45159
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I933a56b3ccbf5bc0e39feed9a2c61be89970dd84
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Fabrice Bacchella <fabrice.bacchella at orange.fr>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list