Change in ovirt-engine[master]: userportal: User portal error message when changing VM clust...

alkaplan at redhat.com alkaplan at redhat.com
Wed Aug 26 12:59:40 UTC 2015


Alona Kaplan has submitted this change and it was merged.

Change subject: userportal: User portal error message when changing VM cluster inconsistent with webadmin
......................................................................


userportal: User portal error message when changing VM cluster inconsistent with webadmin

The error message displayed in user portal when changing
VM cluster is inconsistant with the admin portal. This is
because the user portal invoked first the ChangeVMCluster
command, and then the UpdateVm command, without checking
if the first command was successful. The meaningful message
from the first command was overshaddowed by the less
accurate message from the second command. Now the second
command will only be invoked if the first command was
successful.

Change-Id: I6daaf41c4e09516eb503178b39d3a603dc11c7d1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149092
Signed-off-by: Marcin Mirecki <mmirecki at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Marcin Mirecki: Verified
  Alona Kaplan: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/45150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6daaf41c4e09516eb503178b39d3a603dc11c7d1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list