Change in ovirt-engine[ovirt-engine-3.6]: restapi: Get provider certificates to import from user

tnisan at redhat.com tnisan at redhat.com
Thu Aug 27 13:47:44 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: restapi: Get provider certificates to import from user
......................................................................


restapi: Get provider certificates to import from user

Currently the RESTAPI action used to import provider certificates gets
the certificates to import from the backend and then, in the same
request, it asks the backend to import them. This is not very safe
because there is no guarantee that the caller has ever seen or approved
these certificates. This patch changes the action so that the caller is
forced to send the certificates that are to be approved:

  POST /openstackimageproviders/{provider:id}/importcertificates
  <action>
    <certificates>
      <certificate>the certificate to import</certificate>
    </certificates>
  </action>

The certificates can already be retrieved by the caller as follows:

  GET /openstackimageproviders/{provider:id}/certificates

Change-Id: I8b266fdc6769a84915cb43b9eb97d2f7b4f165b2
Bug-Url: https://bugzilla.redhat.com/1255862
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 1538cae2f7e2dfc02c866de837552a8e798735f4)
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendExternalProviderResource.java
3 files changed, 20 insertions(+), 14 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/45408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8b266fdc6769a84915cb43b9eb97d2f7b4f165b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list