Change in ovirt-engine[master]: core: Removing base templates (backend part)

ahadas at redhat.com ahadas at redhat.com
Tue Dec 1 07:52:50 UTC 2015


Arik Hadas has submitted this change and it was merged.

Change subject: core: Removing base templates (backend part)
......................................................................


core: Removing base templates (backend part)

This patch adds possibility to remote base template even if there are
some sub-templates of that template.

In addition to locking the deleted base template itself, it also shared-
locks the direct successor of deleted base template if there is any.
The lock is acquired in canDoaction() and released at the beginning of
executeCommand() after references to new base template are set.

Change-Id: Iea345cadeb3a02d0f0b82bdd8f4d47a0d6364442
Bug-Url: https://bugzilla.redhat.com/1194989
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDaoImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 119 insertions(+), 18 deletions(-)

Approvals:
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47373
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea345cadeb3a02d0f0b82bdd8f4d47a0d6364442
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <d.mosquito at gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list