Change in ovirt-engine[ovirt-engine-3.6]: engine: update setupNetworks heartbeat policy only for mgmt ...

tnisan at redhat.com tnisan at redhat.com
Wed Dec 2 13:17:20 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: engine: update setupNetworks heartbeat policy only for mgmt networks
......................................................................


engine: update setupNetworks heartbeat policy only for mgmt networks

Updating the heartbeat policy during the HostSetupNetworks command
only makes sense when the connection between the engine and host is
modified. This should only be the case when the management network
is modified.
This patch changes the rpc broker to only reset the heartbeat policy when
the management network is changed in any way.

Change-Id: I49ef2e8d520c5cfff769375a0d5f9428179e87d8
Signed-off-by: Marcin Mirecki <mmirecki at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1262051
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostSetupNetworksVdsCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java
10 files changed, 78 insertions(+), 16 deletions(-)

Approvals:
  Marcin Mirecki: Verified
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49ef2e8d520c5cfff769375a0d5f9428179e87d8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list