Change in ovirt-engine[master]: webadmin: isOptionEnabledOnVolume filters

amureini at redhat.com amureini at redhat.com
Thu Dec 3 10:31:20 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: isOptionEnabledOnVolume filters
......................................................................


webadmin: isOptionEnabledOnVolume filters

isOptionEnabledOnVolume receives a list of filters, but is always
called with a singlton list containing a single element. Taking into
consideration that this code was not touched for over a year, the method
can be simplified to receive a single filter, in order to make it easier
to read.

In the future, if additional filters are required, this patch could
always be reverted.

Change-Id: Ide95e55e72f082e3969857b8e3ba13d668316130
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
1 file changed, 5 insertions(+), 8 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49617
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide95e55e72f082e3969857b8e3ba13d668316130
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list