Change in ovirt-engine[master]: core: Remove ListUtils#firstMatch

amureini at redhat.com amureini at redhat.com
Mon Dec 7 12:48:13 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove ListUtils#firstMatch
......................................................................


core: Remove ListUtils#firstMatch

Removed ListUtils#firstMatch and replaced it with calls to Java 8's new
streaming API as part of the attempt to remove ListUtils completely.

As an added bonus, this new implementation offers a slight performance
improvement by using a HashSet's contains method instead of performing a
binary search in a sort array.

Change-Id: I6eb9ba31753ecf4508dd2a5ed4f80236f6d67526
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ListUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ListUtilsTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
4 files changed, 15 insertions(+), 44 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/49915
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6eb9ba31753ecf4508dd2a5ed4f80236f6d67526
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list