Change in ovirt-engine[master]: core: RestoreCinderSnapshot should delete volumes by order.

mlipchuk at redhat.com mlipchuk at redhat.com
Tue Dec 8 06:29:49 UTC 2015


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: RestoreCinderSnapshot should delete volumes by order.
......................................................................


core: RestoreCinderSnapshot should delete volumes by order.

Re-implement restore Cinder snapshot to delete a Cinder volume and all
its descendants from the DB by calling RemoveCinderDiskVolume for each
volume by order.

The order is important for since Cinder can only remove volume after all
its snapshots get deleted first.

Change-Id: Ife6ac08ca86a4cb2b30174e3de6422d9db5cbb65
Bug-Url: https://bugzilla.redhat.com/1256048
Bug-Url: https://bugzilla.redhat.com/1256049
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreFromCinderSnapshotCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreFromCinderSnapshotCommandCallback.java
2 files changed, 41 insertions(+), 214 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/49419
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife6ac08ca86a4cb2b30174e3de6422d9db5cbb65
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list