Change in ovirt-engine[ovirt-engine-3.6]: core: Refactor, Use RemoveCinderVolumeParentCommand method.

tnisan at redhat.com tnisan at redhat.com
Tue Dec 8 15:24:15 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: Refactor, Use RemoveCinderVolumeParentCommand method.
......................................................................


core: Refactor, Use RemoveCinderVolumeParentCommand method.

Make RemoveCinderDiskCommand to use methods from the parent
command.
The difference in the parent command is that we also pass the
storage id of the volume.

Change-Id: I49ebcbfff3b584e39d20dec0b686e2879e30d650
Bug-Url: https://bugzilla.redhat.com/1256048
Bug-Url: https://bugzilla.redhat.com/1256049
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java
2 files changed, 7 insertions(+), 129 deletions(-)

Approvals:
  Tal Nisan: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/50060
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49ebcbfff3b584e39d20dec0b686e2879e30d650
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list