Change in ovirt-engine[ovirt-engine-3.6]: engine: Introduce KeyValueFormatValidation

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Dec 11 07:57:11 UTC 2015


Piotr Kliczewski has submitted this change and it was merged.

Change subject: engine: Introduce KeyValueFormatValidation
......................................................................


engine: Introduce KeyValueFormatValidation

validation for <key>=<value> spaced separated format.

Please note that extra space is needed in the message ( < key >=< value >) as the message is
being translating to html.
The value between the <> is not being shown.
The usage of &lt &gt was avoided in order to make the language translation easier.

Bug-Url: https://bugzilla.redhat.com/1167812
Change-Id: I78ae0322d49356ba0ef9e0e496a232348a715eef
Signed-off-by: Eliraz Levi <elevi at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/KeyValueFormatValidation.java
A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/KeyValueFormatValidationTest.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
4 files changed, 201 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Passed CI tests
  Eliraz Levi: Verified
  Alona Kaplan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78ae0322d49356ba0ef9e0e496a232348a715eef
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list