Change in ovirt-engine[master]: webadmin: Handle ClassCastException in import VM/template po...

tnisan at redhat.com tnisan at redhat.com
Sun Dec 13 13:39:27 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Handle ClassCastException in import VM/template popups
......................................................................


webadmin: Handle ClassCastException in import VM/template popups

When importing a VM or template, before there was the possibility to select
a destination storage domain per disk we had a default storage domain
selection, this is not used or visible for quite some time now and aside
for throwing ClassCastException this model did nothing.
Up till recently, UI exceptions did not propagate to the client and was
ignored, now when UI exceptions are logged at the client it is visible to
the user, this patch removes the remnant of this redundant model thus
preventing the ClassCastException.

Bug-Url: https://bugzilla.redhat.com/1289037
Change-Id: I9c1b69b81e01bd82265927fefb4e781969f15b14
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.ui.xml
4 files changed, 8 insertions(+), 56 deletions(-)

Approvals:
  Tal Nisan: Verified
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50259
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c1b69b81e01bd82265927fefb4e781969f15b14
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list