Change in ovirt-engine[master]: core: ObjectUtils.haveSameElements performance

amureini at redhat.com amureini at redhat.com
Sun Dec 13 14:51:38 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: ObjectUtils.haveSameElements performance
......................................................................


core: ObjectUtils.haveSameElements performance

If c1 and c2 are known to have the same size, it's redundant to check
that both collections contain each other's elements - it's sufficient to
check whether c1.containsAll(c2).

Change-Id: I6a45e7b26d052e69cbc5f695c1c839bfaae6ad53
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ObjectUtils.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50389
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a45e7b26d052e69cbc5f695c1c839bfaae6ad53
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list