Change in ovirt-engine[master]: frontend: Remove CloneVmWidget and VmDiskAttachPopupWidget l...

tjelinek at redhat.com tjelinek at redhat.com
Tue Dec 15 09:51:48 UTC 2015


Tomas Jelinek has submitted this change and it was merged.

Change subject: frontend: Remove CloneVmWidget and VmDiskAttachPopupWidget localize()
......................................................................


frontend: Remove CloneVmWidget and VmDiskAttachPopupWidget localize()

Moved manual setting of label/text properties to ui.xml file, since method
contained no additional logic to setting it declaratively in the ui.xml file.

Change-Id: If4c464cf66a71c13d45138f362ac631a270b1806
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml
6 files changed, 26 insertions(+), 64 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Martin Betak: Verified
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/50174
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4c464cf66a71c13d45138f362ac631a270b1806
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list