Change in ovirt-engine[master]: checkstyle: Enabled method name checking

amureini at redhat.com amureini at redhat.com
Wed Dec 16 14:36:28 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: checkstyle: Enabled method name checking
......................................................................


checkstyle: Enabled method name checking

Following a series of patches to rename methods throughout the
project, this patch enables the MethodName checkstyle check. The
following cases are excluded, where leaving them untouched actually
helps readability:

* X86_64 methods
* Test methods of the form subSome_someCondition() or
  testSomeMethod_someCondition()
* Methods in GWT-related classes that follow their own standards

Change-Id: I5593feb3cbf09b240e5f8de9abe0f6d740ca68aa
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml
M build-tools-root/checkstyles/src/main/resources/checkstyle.xml
2 files changed, 47 insertions(+), 0 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49910
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5593feb3cbf09b240e5f8de9abe0f6d740ca68aa
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list