Change in ovirt-engine[ovirt-engine-3.6]: core: add template with Cinder disks - failure flow

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Dec 18 07:53:08 UTC 2015


Piotr Kliczewski has submitted this change and it was merged.

Change subject: core: add template with Cinder disks - failure flow
......................................................................


core: add template with Cinder disks - failure flow

* Integrated ConcurrentChildCommandsExecutionCallback on AddVmTemplateCommand.
* Removing JsonIgnore from JsonAddVmTemplateParametersMixIn
is still required as 'MasterVm' is being used on failure flow.

Change-Id: I130071a5aed7f65b0f7072aa86e03575f5d44c81
Bug-Url: https://bugzilla.redhat.com/1287771
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonAddVmTemplateParametersMixIn.java
6 files changed, 37 insertions(+), 20 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Verified
  Maor Lipchuk: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/50635
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I130071a5aed7f65b0f7072aa86e03575f5d44c81
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list