Change in ovirt-engine[master]: core: Remove VM#runOnce

amureini at redhat.com amureini at redhat.com
Wed Dec 23 14:42:49 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove VM#runOnce
......................................................................


core: Remove VM#runOnce

The private field VM#runOnce is never set, and is only read in the
hashCode() method. Hence, it could savely be removed.

It's worth noting that a VM actually does have a runOnce property
exposed by the isRunOnce() and setRunOnce(boolean) methods, but it's
value is stored by the VmDynamic object the VM holds.

Change-Id: Icbf21832633d0b0ff86abde7af3fae4388c8180b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50956
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icbf21832633d0b0ff86abde7af3fae4388c8180b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list