Change in ovirt-engine[ovirt-engine-3.6]: engine : Fix scenario where CoCo child executes Async Tasks

tnisan at redhat.com tnisan at redhat.com
Wed Dec 23 17:59:20 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: engine : Fix scenario where CoCo child executes Async Tasks
......................................................................


engine : Fix scenario where CoCo child executes Async Tasks

When CoCo command with callback executes a command that
starts an async task the endSuccessfully of the CoCo command
is being invoked as it is the parent of command that executes
the async task.

The CoCo command with callback should not be considered parent of
the command executing async task.

Change-Id: Ib3261800f383a6e3973acab4bd16079594fa4149
Bug-Url: https://bugzilla.redhat.com/1293644
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoImpl.java
M packaging/dbscripts/command_entities_sp.sql
A packaging/dbscripts/upgrade/03_06_1970_add_cmd_entity_parent_command_id.sql
13 files changed, 120 insertions(+), 114 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/50910
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3261800f383a6e3973acab4bd16079594fa4149
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list