Change in ovirt-engine[ovirt-engine-3.6]: engine: Add default graphics devices if absent in OVF

tnisan at redhat.com tnisan at redhat.com
Thu Dec 31 15:25:38 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: engine: Add default graphics devices if absent in OVF
......................................................................


engine: Add default graphics devices if absent in OVF

If OVF was created on pre-3.6 version of the Engine, graphics devices
will be absent in it. After restoration under Engine 3.6, the VM without
graphics devices will fail to open the console or even fail to run (on
recent versions of VDSM).

This patch creates graphics devices, if absent after reading an OVF.
The device type (protocol) is guessed from default display type of the
VM.

Change-Id: I596cbb9af4573fd25d1072c911227fb3bd759e0b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1293299
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java
2 files changed, 97 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/51192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I596cbb9af4573fd25d1072c911227fb3bd759e0b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list