Change in ovirt-engine[master]: core: StorageHandlingCommandBase, Config values cleanup.

tnisan at redhat.com tnisan at redhat.com
Thu Feb 5 11:43:09 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: StorageHandlingCommandBase, Config values cleanup.
......................................................................


core: StorageHandlingCommandBase, Config values cleanup.

getSupportedStorageFormats function in StorageHandlingCommandBase is out of
date since format matching to storage needs to be done with
VersionStorageFormatUtil. Hence the config value SupportedStorageFormats
that was used by that function was also removed.

Change-Id: Ia0c9bdc034fd09054ab11137bbc372514d3e74bc
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
6 files changed, 3 insertions(+), 27 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Amit Aviram: Verified
  Liron Aravot: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/36318
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0c9bdc034fd09054ab11137bbc372514d3e74bc
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list